-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Exploring Datasets on Local File System #7389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm3
commented
Oct 16, 2023
@@ -43,6 +43,8 @@ class CredentialService @Inject()(credentialDAO: CredentialDAO) { | |||
secret <- credentialSecret | |||
secretJson <- tryo(Json.parse(secret)).toOption | |||
} yield GoogleServiceAccountCredential(uri.toString, secretJson, userId.toString, organizationId.toString) | |||
case _ => | |||
None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was where the match error originated in case of an unknown uri scheme. That shouldn’t happen.
fm3
commented
Oct 16, 2023
@@ -15,19 +14,19 @@ trait BucketProvider extends FoxImplicits with LazyLogging { | |||
def remoteSourceDescriptorServiceOpt: Option[RemoteSourceDescriptorService] | |||
|
|||
// To be defined in subclass. | |||
def loadFromUnderlying(readInstruction: DataReadInstruction)(implicit ec: ExecutionContext): Fox[DataCubeHandle] = | |||
def openShardOrArrayHandle(readInstruction: DataReadInstruction)(implicit ec: ExecutionContext): Fox[DataCubeHandle] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some renamings here
fm3
changed the title
WIP: Allow Exploring Datasets on Local File System
Allow Exploring Datasets on Local File System
Oct 16, 2023
normanrz
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file://
uris with absolute paths for the local file system.datastore.localFolderWhitelist
file://
uris also in the resulting datasource-properties.jsons. Those will not be sensibly explorable by theWebknossosZarrExplorer
but I guess that isn’t a use case anywaySteps to test:
datastore.localFolderWhitelist
file://
to the absolute path (so there are then three consecutive slashes)TODOs:
Issues: